fix: add tab card height and overflow styling to document editor#4555
fix: add tab card height and overflow styling to document editor#4555czwe-01 wants to merge 2 commits intoshesha-io:mainfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughA styling adjustment introduces a new constant for tab card height and updates the documentation editor area to calculate its vertical size by subtracting both header and tab card heights from the viewport height, with automatic overflow handling. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@shesha-reactjs/src/configuration-studio/styles.ts`:
- Line 23: The stylesheet uses a magic constant tabCardHeight (tabCardHeight =
4) and computes editor heights from 100vh minus that offset, which is brittle;
change the layout so the editor fills its parent container instead of doing
viewport math: remove usage of tabCardHeight and any 100vh-based height
calculations in styles.ts and switch the editor/container rules (where
tabCardHeight is referenced, including the occurrence around line 106) to use
height: 100% or flex/grid sizing so the editor inherits the constrained parent
height, ensuring the editor/container classes and any related selectors are
updated to use container-driven sizing.
1 participant
#4552
Summary by CodeRabbit